Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configuration offline/online mode(Xd-216) #255

Merged
merged 21 commits into from
Jul 15, 2024
Merged

feat: Configuration offline/online mode(Xd-216) #255

merged 21 commits into from
Jul 15, 2024

Conversation

KonsumGandalf
Copy link
Collaborator

Closes: #216

Integrates an online offline mode

KonsumGandalf and others added 20 commits July 13, 2024 12:50
@Persists
feat(common-backend-insight-hub): iot time series
85b7084 
Add functionality to check if session is runned locally

Co-authored-by: Jonas <[email protected]>
@Persists
docs: env
0589e53 
Add env explanations

Co-authored-by: Jonas <[email protected]>
@Persists
revert(common-backend-insight-hub): onModuleInit
3633065 
Add functionality to check if session is runned locally

Co-authored-by: Jonas <[email protected]>
@Persists
revert(common-backend-insight-hub): onModuleInit
52b5bd3 
Add functionality to check if session is runned locally

Co-authored-by: Jonas <[email protected]>
@Persists
revert(common-backend-insight-hub): onModuleInit
d090b94 
Add functionality to check if session is runned locally

Co-authored-by: Jonas <[email protected]>
@Persists
refactor(backend): insight hub key optional
4e20135 
Co-authored-by: Jonas <[email protected]>
@Persists
refactor(facilities-backend-timeseries): services, controller
bfc2b0f 
Add timeseries and offline online functionality

Co-authored-by: Jonas <[email protected]>
@Persists
refactor(facilities-backend-timeseries): services, controller
c960477 
Add timeseries and offline online functionality

Co-authored-by: Jonas <[email protected]>
@Persists
refactor: prisma
b3aa819 
adjust seed script

Co-authored-by: Jonas <[email protected]>
@Persists
feat(common-backend-swagger): metrics route
5986c0d 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(backend): metrics module
e05a78e 
Co-authored-by: Jonas <[email protected]>
style: primsa
63cafe4
@Persists
docs: add key description
9b49844 
Co-authored-by: Jonas <[email protected]>
@Persists
build: metrics lib
7c856ee 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(common-backend-insight-hub): integrate local functionality
6f49ab6 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(facilities-backend-metrics): integrate metrics lib
bd6d5bb 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(facilities-backend-metrics): integrate metrics lib
5e782f1 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(facilities-backend-timeseries): services
64d3661 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(facilities-frontend-domain): metrics request services
15cb3e0 
Co-authored-by: Jonas <[email protected]>
@Persists
feat(facilities-frontend-view): set metrics height
2f39557 
Co-authored-by: Jonas <[email protected]>
@KonsumGandalf KonsumGandalf linked an issue Jul 13, 2024 that may be closed by this pull request
Configuration offline/online mode #216
Closed
IngoSternberg
IngoSternberg reviewed Jul 13, 2024
View reviewed changes
libs/facilities/backend/timeseries/src/lib/services/timeseries.service.ts Outdated
// }),
// );
// }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out function should be removed

IngoSternberg
IngoSternberg approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@IngoSternberg IngoSternberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I just tested it locally and dont really understand the backend part. From what I can tell you also fixed the metrics stuff being null sometimes, right?

But the frontend stuff looks good, I like the change in the details.facade.ts that we have separate functions for pumpData/envData and have less logic in the details.page.ts

Also the change to show the temperature data of the last 24 hours makes sense as it was often just a straight line before.

Just remove that one long comment, apart from that it LGTM

@KonsumGandalf
Copy link
Collaborator Author

I have to admit I just tested it locally and dont really understand the backend part. From what I can tell you also fixed the metrics stuff being null sometimes, right?

But the frontend stuff looks good, I like the change in the details.facade.ts that we have separate functions for pumpData/envData and have less logic in the details.page.ts

Also the change to show the temperature data of the last 24 hours makes sense as it was often just a straight line before.

Just remove that one long comment, apart from that it LGTM

Thanks again for the very fast reply! I ve fixed the commented struct now and will merge it.

@Persists @IngoSternberg
refactor: remove comment
fa68a62 
Co-authored-by: Ingo Sternberg <[email protected]>
Signed-off-by: Jonas <[email protected]>
@Persists Persists self-requested a review July 15, 2024 08:01
@KonsumGandalf KonsumGandalf merged commit a864c73 into develop Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngoSternberg IngoSternberg IngoSternberg approved these changes

@Persists Persists Persists approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuration offline/online mode
3 participants
@KonsumGandalf @Persists @IngoSternberg