feat: added empty states everywhere and adjusted the content headers #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Schmidt <[email protected]> #244
libs/facilities/frontend/view/src/lib/components/browse/browse.page.html
Outdated
Show resolved
Hide resolved
libs/facilities/frontend/view/src/lib/components/browse/browse.page.html
Show resolved
Hide resolved
libs/facilities/frontend/view/src/lib/components/detail/detail.page.html
Outdated
Show resolved
Hide resolved
libs/facilities/frontend/view/src/lib/components/browse/browse.page.html
Show resolved
Hide resolved
libs/cases/frontend/view/src/lib/components/detail-case/detail-case.component.html
Outdated
Show resolved
Hide resolved
libs/facilities/frontend/view/src/lib/components/browse/browse.page.html
Show resolved
Hide resolved
IngoSternberg
requested changes
Jul 14, 2024
There was a problem hiding this comment.
I found a couple of things but it should be easy fixes. Very nice that you
- added the extra message for no facilities with issues
- did
@if(!facilities())or@if(!cases())so we had the empty state at the start of the html (easier to read in my opinion) - added actions for the empty states
- added a message on the create case page if there are no facilities
- good fix with the title of the cases page (it was my bad, I copied the content header of the facilities details and forgot to change it)
…lities with issues empty state #244 Co-authored-by: Ingo Sternberg <[email protected]> Signed-off-by: Patrick Schmidt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Schmidt [email protected]
#244