Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge to core repo clone #122 #126

Open
wants to merge 101 commits into
base: merge/core-develop-clone
Choose a base branch
from
Open

Merge to core repo clone #122 #126

wants to merge 101 commits into from
+3,718 −889

Conversation

dh1542
Copy link

@dh1542 dh1542 commented Jan 18, 2025

No description provided.

Timm638 and others added 30 commits December 3, 2024 00:44
@Timm638
Started to refactor Arima
c47809d 
- Adds Input Validator
- Refactors helper methods out of arima.py

Signed-off-by: Timm638 <[email protected]>
@Timm638
refactors arima.py
37fb408 
- Update workaround to take from project
- Removed unnecessary variable assignment

Signed-off-by: Timm638 <[email protected]>
@Timm638
Merge branch 'develop' into feature/040_finishing_ARIMA
8aae6df
@FelipeTrost
feat: schema validation for anomaly detection
756fa7f 
Signed-off-by: Felipe Trost <[email protected]>
@Timm638
refactors arima.py for preparation of exogenous variables
5f98b56 
Signed-off-by: Timm638 <[email protected]>
@Timm638
refactors AutoArima to its own Component
f0ed1b8 
Signed-off-by: Timm638 <[email protected]>
@FelipeTrost
Merge remote-tracking branch 'origin/develop' into refactor/63-anomal…
31615ae 
…-detection-tests
@Timm638
adds auto-recognition of column names to ARIMA
d877f29 
Signed-off-by: Timm638 <[email protected]>
@Timm638
cleans up RegEx
3da1ef3 
Signed-off-by: Timm638 <[email protected]>
@Timm638
tries to implement exog
e4510af 
Signed-off-by: Timm638 <[email protected]>
@Timm638
splits up Arima into two files
2601544 
Signed-off-by: Timm638 <[email protected]>
@Timm638
prepare test data in test_arima.py
fbba3ff 
Signed-off-by: Timm638 <[email protected]>
@FelipeTrost
Merge remote-tracking branch 'origin/develop' into refactor/63-anomal…
d2bad25 
…-detection-tests
@FelipeTrost
test: ksigma anomaly detection, wrong values and large data set
8668431 
Signed-off-by: Felipe Trost <[email protected]>
@chris-1187
refactorings on #61 and #92
7689d08 
Signed-off-by: chris-1187 <[email protected]>
@chris-1187
actions adjustment
738b1cf 
Signed-off-by: chris-1187 <[email protected]>
@chris-1187
#65 ARIMA refactorings
b26682a 
Signed-off-by: chris-1187 <[email protected]>
@Timm638
cleans up test
cbca20f 
Signed-off-by: Timm638 <[email protected]>
@dh1542
Merge pull request #102 from amosproj/refactor/#92-MVI_#61-DD
8448a76 
refactorings on #61,#65 and #92
#66 add datatype validation and prediction on large dataset
c3e185b 
Signed-off-by: Minh Khue Tran <[email protected]>
validate datatype
2242257 
Signed-off-by: Minh Khue Tran <[email protected]>
refactor invalid datatype
ba5873d 
Signed-off-by: Minh Khue Tran <[email protected]>
@dh1542
Merge pull request #103 from amosproj/refactor/066_linear_regression_…
cd0640d 
…test

refactor/066_linear_regression
@Timm638
documents code & finishes up column-conversion
a0f2575 
Signed-off-by: Timm638 <[email protected]>
@Timm638
Merge branch 'develop' into feature/040_finishing_ARIMA
5132629
@Timm638
adapted test cases to new ARIMA structure
b960d1d 
Signed-off-by: Timm638 <[email protected]>
@Timm638
applies Black linter
1019bfa 
Signed-off-by: Timm638 <[email protected]>
@Timm638
applies workaround to test dataframes
ba31917 
Signed-off-by: Timm638 <[email protected]>
@Timm638
fixes import
099fa56 
Signed-off-by: Timm638 <[email protected]>
@dh1542
Merge pull request #94 from amosproj/feature/040_finishing_ARIMA
c7658a0 
#40: Finishing Arima
TugceOzberkYener
TugceOzberkYener suggested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@TugceOzberkYener TugceOzberkYener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 comments regarding with the mkdocs documentation and package renaming for component locations. Could you please apply the requested changes.

This was referenced Jan 21, 2025
Closed
Closed
@luccalb
Copy link

luccalb commented Jan 21, 2025

@TugceOzberkYener thank you for your feedback!
I've created two followup Issues to take care of your comments #128 and #129 which we will plan for this sprint.

mollle and others added 24 commits January 21, 2025 10:16
@mollle
Merge branch 'develop' into feature/107_MovingAverage
cc012f5 
Signed-off-by: mollle <[email protected]>
@dh1542
Merge pull request #125 from amosproj/feature/107_MovingAverage
3018a3d 
107 moving average done
Add deliverables for sprint-12
3170bd3 
Signed-off-by: Minh Khue Tran <[email protected]>
Merge branch 'develop' of https://github.com/amosproj/amos2024ws01-rt…
d114ba3 
…dip-data-quality-checker into develop
@mollle
improving/fixing documentation
4ceb318 
Signed-off-by: mollle <[email protected]>
@mollle
fixed/improved docu, renamed "machine_learning" into "forecasting"
4fcf3a7 
Co-authored-by: Felipe Trost <[email protected]>

Signed-off-by: mollle <[email protected]>
@mollle
fixing tests that broke because of refactoring
9cd320d
@mollle
fixed arima test
1b9e5ab 
Signed-off-by: mollle <[email protected]>
#105 refactor for only euclidean distance
9d062e7
#105 add parameters for time series prediction
d80ec71 
Signed-off-by: Minh Khue Tran <[email protected]>
#105 add unit test for KNN
254f90f 
Signed-off-by: Minh Khue Tran <[email protected]>
refactor
9b25452 
Signed-off-by: Minh Khue Tran <[email protected]>
linted
11c6db9 
Signed-off-by: Minh Khue Tran <[email protected]>
debug import error
eb35dae 
Signed-off-by: Minh Khue Tran <[email protected]>
#105 Rename machine_learning to forecasting folder
083fab3 
Signed-off-by: Minh Khue Tran <[email protected]>
@kristen149
Merge branch 'develop' into feature/105_KNN
9aa0a6a 
Signed-off-by: Minh Khue Tran <[email protected]>
@GBBBAS
Refactor Time Series Builder Queries for Raw, Resample and Interpolate (
3eef96c 
rtdip#859)

* Refactor Time Series Builder Queries for Raw, Resample and Interpolate

Signed-off-by: GBBBAS <[email protected]>

* Add tests for 3.5.2

Signed-off-by: GBBBAS <[email protected]>

---------

Signed-off-by: GBBBAS <[email protected]>
@GBBBAS
Update tests (rtdip#860)
3c11b35 
Signed-off-by: GBBBAS <[email protected]>
@kristen149
Delete tests/sdk/python/rtdip_sdk/pipelines/forecasting/__init__.py
e500c5a 
Signed-off-by: Minh Khue Tran <[email protected]>
@kristen149
Delete tests/sdk/python/rtdip_sdk/pipelines/forecasting/spark/__init_…
d3a32ce 
…_.py

Signed-off-by: Minh Khue Tran <[email protected]>
@kristen149
Linted formatting
cef5823 
Signed-off-by: Minh Khue Tran <[email protected]>
@mollle
Merge pull request #136 from amosproj/feature/105_KNN
5c9c8a4 
Feature/105_K Nearest Neighbors
@dh1542
Merge branch 'develop' into merge/to-core
8eb8168
@dh1542
#126: Merged new changes from develop
66ee048 
Signed-off-by: Dominik Hoffmann <[email protected]>
@dh1542
Copy link
Author

dh1542 commented Jan 28, 2025

@TugceOzberkYener We implemented the feedback. Can you take a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TugceOzberkYener TugceOzberkYener TugceOzberkYener requested changes

@Amber-Rigg Amber-Rigg Awaiting requested review from Amber-Rigg

Assignees

@dh1542 dh1542

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new (final) PR for Shell to review
9 participants
@dh1542 @TugceOzberkYener @luccalb @Timm638 @FelipeTrost @chris-1187 @mollle @kristen149 @GBBBAS