Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Add overlay mode for time series #220

Merged
merged 3 commits into from
Jan 21, 2025
Merged

[UI] Add overlay mode for time series #220

merged 3 commits into from
Jan 21, 2025
+1,012 −134

Conversation

luca-dot-sh
Copy link
Contributor

@luca-dot-sh luca-dot-sh commented Jan 21, 2025 •
edited
Loading

This PR

  • adds the overlay mode
  • adds overlay launcher to visualization
  • renames bl package to platform
  • reuses the existing visualizations with Vico with changed color

Limitations:

  • currently only for timeseries data
  • OverlayService can be killed on low memory -> should use foreground service and persistent notification
  • background color/ transparency not changable -> should be an option
  • time series length should ideally be scaled with the overlay
overlay_proto_4.webm

Closes: #178

@luca-dot-sh luca-dot-sh changed the base branch from main to dev January 21, 2025 21:10
@luca-dot-sh luca-dot-sh requested a review from fhilgers January 21, 2025 21:10
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
frontend/app/src/main/java/de/amosproj3/ziofa/ui/overlay/OverlayRoot.kt Fixed Show fixed Hide fixed
frontend/app/src/main/java/de/amosproj3/ziofa/ui/overlay/OverlayRoot.kt Fixed Show fixed Hide fixed
frontend/app/src/main/java/de/amosproj3/ziofa/ui/overlay/OverlayRoot.kt Fixed Show fixed Hide fixed
frontend/app/src/main/java/de/amosproj3/ziofa/ui/overlay/OverlayViewModelStoreOwner.kt Fixed Show fixed Hide fixed
...main/java/de/amosproj3/ziofa/ui/visualization/composables/overlay/OverlayPositionSelector.kt Fixed Show fixed Hide fixed
...main/java/de/amosproj3/ziofa/ui/visualization/composables/overlay/OverlayPositionSelector.kt Fixed Show fixed Hide fixed
...app/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/viewers/OverlayLauncher.kt Fixed Show fixed Hide fixed
...app/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/viewers/OverlayLauncher.kt Fixed Show fixed Hide fixed
...app/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/viewers/OverlayLauncher.kt Fixed Show fixed Hide fixed
...app/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/viewers/OverlayLauncher.kt Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 21, 2025
View reviewed changes
...end/app/src/main/java/de/amosproj3/ziofa/ui/visualization/composables/viewers/ChartViewer.kt
import de.amosproj3.ziofa.ui.visualization.data.GraphedData

@Composable
fun ChartViewer(data: GraphedData) {

Check warning

Code scanning / detekt

This @Composable function emits content but doesn't have a modifier parameter. See https://twitter.github.io/compose-rules/rules/#when-should-i-expose-modifier-parameters for more information. Warning

This @Composable function emits content but doesn't have a modifier parameter. See https://twitter.github.io/compose-rules/rules/#when-should-i-expose-modifier-parameters for more information.
@fhilgers fhilgers merged commit b1cfe3c into dev Jan 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhilgers fhilgers fhilgers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luca-dot-sh @fhilgers