Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Packages Preperation #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davisadam10
Copy link
Collaborator

We are now at a point where this is very close to doing everything that was intended and more, I want to start the discussion of how we can publish these to pypi so we can install with regular pip workflows etc.

I had to make a small change to the .toml file as we now have multiple packages within the repo so had to tell the poetry build command what to do.

This works and a whl is produce which can be installed and runs perfectly well.

However it brings us back to an older discussion

  1. The aces.idt package seperate from the app package

Right now when we build the whl we get a single package which includes both the aces package and the apps package.
Including the apps package introduces a lot of web ui dependencies that we do not really want to include if you only want to use the core modules etc.

This would mean we need to do a minor cleanup moving the tests back under the relevent package (sorry thomas i know you had it that way to start), and adding a seperarte .toml file in each package so we can publish the aces package seperate from the apps package

Dragging in all the additional flask related stuff is going to cause conflicts and bloat

This feels like the best thing to do but want to have that conversation

  1. Where are we publishing and what are we naming these packages

Obviously in that case we cant publish a package called "apps" so we will need to name that?
Then where and under what names do we want to publish these packages?

  1. CI/CD
    Ideally once this is working we then extend the CI/CD to get this runnig tests, building and publishing

Adding the subfolders so we have multiple packages in the build
We probably do not wnat this and should move to multiple toml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant