Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: amplitude.remove should only remove if plugin was already registered #936

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: amplitude.remove should only remove if plugin was already registered #936

merged 2 commits into from
Dec 17, 2024

Conversation

izaaz
Copy link
Contributor

@izaaz izaaz commented Dec 17, 2024

Summary

Currently, calling amplitude.remove(badPluginName) will remove the last registered plugin. Fixing that issue

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@izaaz izaaz requested a review from Mercy811 December 17, 2024 00:57
Mercy811
Mercy811 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Izaaz for fixing it. See nit.

packages/analytics-core/src/timeline.ts Outdated Show resolved Hide resolved
@izaaz izaaz merged commit dd6d235 into main Dec 17, 2024
4 checks passed
@izaaz izaaz deleted the AMP-120673/fix_amp_remove branch December 17, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercy811 Mercy811 Mercy811 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izaaz @Mercy811