Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update script library #939

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Conversation

Mercy811
Copy link
Contributor

Summary

  • Change library to amplitude-ts-sdk-script in amplitude-min.js which is renamed as analytics-browser-x.x.x-min.js.gzand uploaded to s3 at
    const files = ['amplitude-min.js.gz', 'amplitude-min.umd.js.gz'];
  • The main goal is to be able to distinguish installation methods: script vs npm/yarn which remains to be amplitude-ts
// install by script example
<script src="https://cdn.amplitude.com/libs/analytics-browser-2.11.10-min.js.gz"></script>
  • Keep this as part of rollup instead of updating amplitude-min.js to avoid amplitude-min.js is used before library updated
  • library in lib/esm and lib/cjs remains amplitude-ts
image

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

scripts/build/rollup.config.js Show resolved Hide resolved
scripts/build/rollup.config.js Show resolved Hide resolved
scripts/build/rollup.config.js Show resolved Hide resolved
@Mercy811 Mercy811 requested a review from chungdaniel December 24, 2024 22:13
scripts/build/rollup.config.js Show resolved Hide resolved
scripts/build/rollup.config.js Show resolved Hide resolved
@Mercy811 Mercy811 merged commit 374d8aa into main Dec 26, 2024
4 checks passed
@Mercy811 Mercy811 deleted the AMP-119515-change-script-library branch December 26, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants