Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitization of XFBML raw embeds into amp-facebook #5506

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

westonruter
Copy link
Member

Summary

I'm just opening this PR as a potential starting point for converting <fb:post> into <amp-facebook>, where fb:post is the XFBML version of what Facebook now has replaced with div.fb-post. Jetpack was using fb:post which is why this issue was discovered, but I've opened Automattic/jetpack#17492 to update Jetpack to use div.fb-post instead. Once that is released, this PR should be very low priority since XFBML is not the current best practice.

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added P2 Low priority Embeds labels Oct 15, 2020
@google-cla google-cla bot added the cla: yes Signed the Google CLA label Oct 15, 2020
@westonruter westonruter added the WS:Core Work stream for Plugin core label Oct 22, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA Embeds P2 Low priority WS:Core Work stream for Plugin core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants