Skip to content
This repository has been archived by the owner on Oct 18, 2021. It is now read-only.

Shadowing related optimiser fixes #265

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

SquidDev
Copy link
Member

@SquidDev SquidDev commented Jan 26, 2020

It's not perfect (obeys scope, while it should obey the entire program),
but it's a good initial pass.
This is a little over-eager, but it's good enough
@SquidDev SquidDev added bug X-Core Lint Core lint errors in type-checked code. Optimiser Issues and PRs relating to the optimiser labels Jan 26, 2020
This is really horrible, but it's midnight and I want to go to bed.
@SquidDev SquidDev requested a review from plt-amy January 26, 2020 23:57
@plt-amy
Copy link
Member

plt-amy commented Feb 1, 2020

It looks good but I'm worried about the test failures

@SquidDev
Copy link
Member Author

SquidDev commented Feb 1, 2020

Yep, sorry - haven't got round to looking at those. Wasn't honestly expecting them to fail.

SquidDev added a commit that referenced this pull request Feb 10, 2020
This is a little over-eager, but it's good enough

Cherry-picked from #265 in order to fix #264
@plt-amy plt-amy force-pushed the master branch 2 times, most recently from aefe106 to ff37191 Compare May 1, 2020 03:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Optimiser Issues and PRs relating to the optimiser X-Core Lint Core lint errors in type-checked code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce is not inlining an atom
2 participants