Enhancements #971
Merged
Enhancements #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Some exceptions would be handled in a thread. Using this macro that creates a QMessageBox would cause undefined behaviour due to the fact that we are creating GUI elements from another thread. If we can identify that this thread does not correspond to the main thread ie the qapplication's thread we invoke the message box. Due to the fact that "msg.exec()" blocks the main thread we also need to block the current thread, to further prevent more undefined behaviour from being introduced, thus the usage of Qt::BlockingQueuedConnection. If we are on the main thread we can simply create the message box like before Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
This is usefull when printing the plot Signed-off-by: DanielGuramulta <[email protected]>
…ached Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
…utton Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
|
I have pushed some few new changes, @AlexandraTrifan could you review this new changes? Thank you! |
Signed-off-by: DanielGuramulta <[email protected]>
Looks good! I will give it a test run once the appveyor build is finished. |
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Signed-off-by: DanielGuramulta <[email protected]>
Add trace height settings and trigger for given channel Signed-off-by: DanielGuramulta <[email protected]>
|
Should be in final form with all the enhancements. @AlexandraTrifan could you take another look at this. Thank you! |
|
Looks good! |
AlexandraTrifan
approved these changes
Dec 21, 2020
This was referenced Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements enhancements for the Logic tools as described in the following issues: