Add DB v6 feature flag #2288
Open
Add DB v6 feature flag #2288
+1,286
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoodman
added
the
changelog-ignore
wagoodman
force-pushed
the
add-v6-feature-flag
branch
2 times, most recently
from
f3464b5
to
8c5c2ac
Compare
Signed-off-by: Alex Goodman <[email protected]>
wagoodman
force-pushed
the
add-v6-feature-flag
branch
from
8c5c2ac
to
e3c46df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
GRYPE_EXP_DBV6feature flag while we are developing V6 features and wires up thedb *commands to respond to this. The top-level API has not been wired up to respond to this yet, as that will require more breaking changes as well as coordination with the matchers/search work in progress. I've tried to cover new functions in thecommandspackage with tests, but did not add tests for existing functions (most of which did not have tests).DB commands summary:
db check: responds to v6, new tests addeddb delete: responds to v6, tests in curator alreadydb diff: not modifieddb import: responds to v6, tests in curator alreadydb list: responds to v6, new tests addeddb providers: responds to v6, new tests addeddb search: partially implemented v6 pathdb status: responds to v6, new tests addeddb update: responds to v6, tests in curator already