Use VerticalDivider in IntrinsicSnippets #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMendozaMartinez
force-pushed
the
intrinsic_snippets_divider
branch
5 times, most recently
from
7f0c199
to
a1fdfc4
Compare
DavidMendozaMartinez
force-pushed
the
intrinsic_snippets_divider
branch
2 times, most recently
from
8c23af1
to
00ca817
Compare
gblok82
approved these changes
Nov 4, 2024
DavidMendozaMartinez
force-pushed
the
intrinsic_snippets_divider
branch
from
00ca817
to
c83d1b3
Compare
DavidMendozaMartinez
force-pushed
the
intrinsic_snippets_divider
branch
from
c83d1b3
to
dd2a5e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intrinsics in action section uses a divider in a
Rowto explain howIntrinsicSizeworks, but after the deprecation ofDivider, it should have been replaced byVerticalDividerinstead ofHorizontalDivider.The resulting Preview of the current code is as follows:
After the change, the Preview matches the expected one according to the documentation:
