Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

Fix the visibility of the 'Add' button when the content is scrolled #894

Closed
wants to merge 4 commits into from
Closed

Fix the visibility of the 'Add' button when the content is scrolled #894

wants to merge 4 commits into from

Conversation

yosefmoq
Copy link
Contributor

@yosefmoq yosefmoq commented Jul 1, 2023 •
edited
Loading

This pull request fixes issue #889
This PR is part of GTC open source initiative

@yosefmoq yosefmoq requested a review from a team as a code owner July 1, 2023 18:55
@yosefmoq yosefmoq requested a review from mlykotom July 1, 2023 18:55
@yosefmoq yosefmoq changed the base branch from main to views July 2, 2023 07:23
@yosefmoq yosefmoq changed the base branch from views to main July 2, 2023 07:24
arriolac
arriolac suggested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. Best to toggle visibility based on scroll position. Bonus point is to use AnimatedVisibility

@riggaroo
Copy link
Collaborator

riggaroo commented Aug 2, 2024

Hi,
Thanks for your contribution, however Sunflower is going to be archived in favour of maintaining a smaller set of up-to-date set of compose-samples, that can be found here: https://github.com/android/compose-samples, as well as snippets that can be found here: https://github.com/android/snippets.

Please feel free to keep your fork up-to-date for your learning, but this repository will be archived shortly.

@riggaroo riggaroo closed this Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arriolac arriolac arriolac requested changes

@mlykotom mlykotom Awaiting requested review from mlykotom mlykotom is a code owner automatically assigned from android/compose-devrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yosefmoq @riggaroo @arriolac