Merge pull request #52 from andrusha/clippy_fixes

clippy temporary fixes
andrusha · Sep 6, 2024 · 57705c5 · 57705c5
2 parents 8b01068 + fe888f2
commit 57705c5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/snowflake-api/README.md b/snowflake-api/README.md
@@ -18,7 +18,7 @@ Since it does a lot of I/O the library is async-only, and currently has hard dep
 - [x] PUT support [example](./examples/filetransfer.rs)
 - [ ] GET support
 - [x] AWS integration
-- [ ] GCloud integration
+- [ ] `GCloud` integration
 - [ ] Azure integration
 - [x] Parallel uploading of small files
 - [x] Glob support for PUT (eg `*.csv`)

diff --git a/snowflake-api/src/responses.rs b/snowflake-api/src/responses.rs
@@ -12,7 +12,8 @@ pub enum ExecResponse {
 }
 
 // todo: add close session response, which should be just empty?
-#[allow(clippy::large_enum_variant)]
+// FIXME: dead_code
+#[allow(clippy::large_enum_variant, dead_code)]
 #[derive(Deserialize, Debug)]
 #[serde(untagged)]
 pub enum AuthResponse {
@@ -60,6 +61,8 @@ pub struct ExecErrorResponseData {
 
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
+// FIXME: dead_code
+#[allow(dead_code)]
 pub struct AuthErrorResponseData {
     pub authn_method: Option<String>,
     pub error_code: Option<String>,
@@ -73,6 +76,8 @@ pub struct NameValueParameter {
 
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
+// FIXME
+#[allow(dead_code)]
 pub struct LoginResponseData {
     pub session_id: i64,
     pub token: String,
@@ -87,6 +92,8 @@ pub struct LoginResponseData {
 
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
+// FIXME: dead_code
+#[allow(dead_code)]
 pub struct SessionInfo {
     pub database_name: Option<String>,
     pub schema_name: Option<String>,
@@ -96,6 +103,8 @@ pub struct SessionInfo {
 
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
+// FIXME: dead_code
+#[allow(dead_code)]
 pub struct AuthenticatorResponseData {
     pub token_url: String,
     pub sso_url: String,
@@ -104,6 +113,8 @@ pub struct AuthenticatorResponseData {
 
 #[derive(Deserialize, Debug)]
 #[serde(rename_all = "camelCase")]
+// FIXME: dead_code
+#[allow(dead_code)]
 pub struct RenewSessionResponseData {
     pub session_token: String,
     pub validity_in_seconds_s_t: i64,