Add support for custom middleware (eg. tracing) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrusha
requested changes
Feb 7, 2024
There was a problem hiding this comment.
Yes, that's very specific to you functionality to hide behind a feature flag.
I think cleaner solution would be to have a constructor on Connection which accepts ClientWithMiddleware, so you could provide one with whatever middlewares you would like, along with a reasonable default to make using library simpler.
|
Sounds good, when I have some time I'll take a pass at that. |
|
@andrusha I took a crack at a new |
wseaton
changed the title
dmzmk
approved these changes
Feb 21, 2024
andrusha
approved these changes
Feb 21, 2024
|
Could you merge with the main? I've removed nursery linters |
|
@andrusha done! |
|
Tests are failing due to doctest in comment, going to mark to be skipped |
andrusha
reviewed
Feb 21, 2024
Co-authored-by: andrusha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very interested in using this project as an alternative for the
gosnowflakeAPI, but one thing I need to get working is tracing support. This attempts to make that possible via feature flag, and it works great testing with local Jaeger and OTLP as the exporter.Is there a creative way to make this work without forcing users to take
opentelemetry_0_21? Or potentially by allowing aSnowflakeApiinstance to be created with a fully custom client?