Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to be able to run the server #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkanyar
Copy link

@mkanyar mkanyar commented Apr 27, 2022

The command to run the server does not work. What is done in this PR:

  • Cast queryParams.pageNumber as string and queryParams.pageSize as string.
  • Remove to lowercase filter.toLowerCase()
  • Fix Package.json

"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"6": "^0.0.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unneeded

@@ -28,6 +29,7 @@
"core-js": "^2.4.1",
"express": "^4.16.2",
"moment": "^2.22.2",
"npm": "^6.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unneeded

@@ -1,46 +1,41 @@

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes are unrelated to the server issue and should be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants