refactor(material/core): Update internal state of option to use signals #29698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
requested review from
crisbeto and
amysorto
and removed request for
a team
crisbeto
approved these changes
Sep 5, 2024
crisbeto
reviewed
Sep 5, 2024
| @@ -107,10 +108,10 @@ export class MatOption<T = any> implements FocusableOption, AfterViewChecked, On | |||
| /** Whether the option is disabled. */ | |||
| @Input({transform: booleanAttribute}) | |||
| get disabled(): boolean { | |||
| return (this.group && this.group.disabled) || this._disabled; | |||
| return (this.group && this.group.disabled) || this._disabled(); | |||
There was a problem hiding this comment.
Should we migrate the group as well and turn this into a computed?
There was a problem hiding this comment.
Hmmm, that's a good thought. It would either require a "breaking" change to the public API of the group or to add a getter/setter pair there so I can set an internal signal.
eneajaho
reviewed
Sep 5, 2024
This updates the internal state to use signals, eliminating any ExpressionChanged... issues when developers programatically update disabled or selected state during change detection.
atscott
force-pushed
the
matOptionSignals
branch
from
5e5a6fc
to
aa42b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the internal state to use signals, eliminating any ExpressionChanged... issues when developers programatically update disabled or selected state during change detection.