refactor: create an m2 system directory #31322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
crisbeto and
ok7sai
and removed request for
a team
andrewseguin
added
the
target: minor
crisbeto
approved these changes
Jun 10, 2025
WORKSPACE
Outdated
| @@ -159,7 +159,7 @@ load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies") | |||
|
|
|||
| rules_ts_dependencies( | |||
| # Obtained by: curl --silent https://registry.npmjs.org/typescript/5.8.2 | jq -r '.dist.integrity' | |||
| ts_integrity = "sha512-aJn6wq13/afZp/jT9QZmwEjDqqvSGp1VT5GVg+f/t6/oVyrgXM6BY1h9BRh/O5p3PlUPAe+WuiEZOmb/49RqoQ==", | |||
| ts_integrity = "sha512-p1diW6TqL9L07nNxvRMM7hMMw4c5XOo/1ibL4aAIGmSAt9slTE1Xgw5KWuof2uTOvCg9BY7ZRi+GaF+7sfgPeQ==", | |||
There was a problem hiding this comment.
I should update that this is 5.8.3, or leave it out. Does your workspace not require this?
There was a problem hiding this comment.
I didn't get any changes like this when I was running the dev app earlier today.
There was a problem hiding this comment.
Hm, seems necessary for my workspace. If it doesnt break you, lets include it
andrewseguin
force-pushed
the
sys-typography
branch
from
b20a4e4 to
7cd3a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-op change that moves M2 system values to mimic M3 system values, with its own directory separated into categories