This repository was archived by the owner on May 22, 2025. It is now read-only.
Fix enum declaration merging in unoptimized namespaces #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_587866111
branch
from
5c6203e to
8b11d1b
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_587866111
branch
from
8b11d1b to
6cfb1ff
Compare
In build targets with --allow_unoptimized_namesapces, emit enum declarations as `var E = {...}` instead of const. That fixes compilation errors when a namespace is merged with the enum.
PiperOrigin-RevId: 587866111
copybara-service
bot
force-pushed
the
test_587866111
branch
from
6cfb1ff to
2dc00a3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix enum declaration merging in unoptimized namespaces
In build targets with --allow_unoptimized_namesapces, emit enum declarations as
var E = {...}instead of const. That fixes compilation errors when a namespace is merged with the enum.