Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum declaration merging in unoptimized namespaces #1489

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix enum declaration merging in unoptimized namespaces #1489

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Dec 5, 2023 •
edited
Loading

Fix enum declaration merging in unoptimized namespaces

In build targets with --allow_unoptimized_namesapces, emit enum declarations as var E = {...} instead of const. That fixes compilation errors when a namespace is merged with the enum.

@copybara-service copybara-service bot changed the title No public description Fix enum declaration merging in unoptimized namespaces Dec 6, 2023
@mhausner @copybara-github
Fix enum declaration merging in unoptimized namespaces
2dc00a3 
In build targets with --allow_unoptimized_namesapces, emit enum declarations as `var E = {...}` instead of const. That fixes compilation errors when a namespace is merged with the enum.

PiperOrigin-RevId: 587866111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhausner