Find Jets in Registry Faster #1784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the layer and door computations explicit in the Jet module.
Prior, the jet registry carried the mug of the parent to compare against. However, mug computations for such large core can be expensive in Elixir due to murmur3 limitations. In order to speed up the process, we now store instead of mugs the actual parents and can compare against them during the jet checks.
Mug lookup is slower in Elixir due to Murmur3 implementation. Instead, our equality is faster and hence should be used in mug's stead. Hence now jet lookup goes through direct equality checking.
agureev
added
the
nock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mug lookup is slower in Elixir due to Murmur3 implementation. Instead,
our equality is faster and hence should be used in mug's stead.
Hence now jet lookup goes through direct equality checking.