Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] - azure_rm_aduser_info Add surname and givenName to user info output #1815

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

rschoebel
Copy link
Contributor

add surname and givenName to user info output

SUMMARY

add surname and givenName to user info output

if some Person has a second given name or an compound surname its impossible to recreate the names

example:
displayname: Kevin Paul Smith
is either:
surname: Smith
givenName: Kevin Paul

or:

surname: Paul Smith
givenName: Kevin


displayname: Kevin van der Whye
is either:
surname: van der Whye
givenName: Kevin

or: somthing wrong

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_aduser_info.py

Add surname and givenName to user info output
Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschoebel Small changes request!

plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_aduser_info.py Outdated Show resolved Hide resolved
@Fred-sun Fred-sun added question Further information is requested medium_priority Medium priority work in In trying to solve, or in working with contributors labels Feb 5, 2025
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Feb 5, 2025
@Fred-sun
Copy link
Collaborator

Fred-sun commented Feb 5, 2025

ready_for_review!

@xuzhang3 xuzhang3 changed the title Add surname and givenName to user info output [Enhance] - azure_rm_aduser_info Add surname and givenName to user info output Feb 5, 2025
@xuzhang3 xuzhang3 merged commit d59b4a7 into ansible-collections:dev Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority question Further information is requested ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants