-
Notifications
You must be signed in to change notification settings - Fork 402
Prep Release 10.0.0
#2307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep Release 10.0.0
#2307
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ❌ ansible-galaxy-importer RETRY_LIMIT in 2m 58s (non-voting) |
Build succeeded. ❌ ansible-galaxy-importer RETRY_LIMIT in 3m 01s (non-voting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the other things I was suggesting in this PR ansible-collections/amazon.aws#2600
Build succeeded. ❌ ansible-galaxy-importer RETRY_LIMIT in 3m 01s (non-voting) |
Build failed.
|
Build failed.
|
CHANGELOG.rst
Outdated
@@ -40,29 +66,24 @@ Minor Changes | |||
v9.1.0 | |||
====== | |||
|
|||
Release Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.1.0 release summary is missing.
Co-authored-by: GomathiselviS <[email protected]>
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 3m 34s (non-voting) |
@@ -4,6 +4,32 @@ community.aws Release Notes | |||
|
|||
.. contents:: Topics | |||
|
|||
v10.0.0 | |||
======= | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why I don't see https://github.com/ansible-collections/community.aws/pull/2303/files? Did I miss it? I guess you need to a changelog_fragment to take in consideration this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note - it looks like #2303 should have included a breaking change changelog fragment. In general, we aim to skip changelogs only for trivial or test-related changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that makes sense. Sorry for the oversight!
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 42s (non-voting) |
d804ced
into
ansible-collections:stable-10
SUMMARY Prep community.aws 10.0.0 Prerequisite: Release of amazon.aws v10.0.0 ISSUE TYPE Feature Pull Request COMPONENT NAME Multiple Reviewed-by: Bianca Henderson <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS <[email protected]> Reviewed-by: Mandar Kulkarni <[email protected]> Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit d804ced)
SUMMARY
Prep
community.aws 10.0.0
Prerequisite: Release of
amazon.aws v10.0.0
ISSUE TYPE
COMPONENT NAME
Multiple