Extension for Ansible redirects #2418
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
37aaddd to
59a6df2
Compare
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
59a6df2 to
c5ec601
Compare
webknjaz
reviewed
Mar 6, 2025
webknjaz
reviewed
Mar 6, 2025
webknjaz
reviewed
Mar 6, 2025
webknjaz
reviewed
Mar 6, 2025
webknjaz
reviewed
Mar 6, 2025
webknjaz
reviewed
Mar 6, 2025
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
768cd3f to
1e48ae3
Compare
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
1e48ae3 to
5641adf
Compare
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
5641adf to
97be9ad
Compare
webknjaz
reviewed
Mar 10, 2025
webknjaz
reviewed
Mar 10, 2025
webknjaz
reviewed
Mar 10, 2025
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
97be9ad to
acdbce4
Compare
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
09a7683 to
910c941
Compare
|
@webknjaz / @felixfontein / @gotmax23 Could we please get another round of reviews here? I've added all the redirects to the ReadTheDocs project and this PR is one of the last hurdles in the way of the |
webknjaz
reviewed
Apr 24, 2025
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
efe854f to
d9ac192
Compare
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
d9ac192 to
de60b45
Compare
oraNod
commented
Apr 29, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
oraNod
force-pushed
the
issue-2147/sphinx-redirects
branch
from
de60b45 to
333b36b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2147 and supercedes #2266
This PR extends the Sphinx reredirects extension to load redirects for Ansible documentation from a toml file. The purpose is to replace the httpd mod_rewrite rules in https://github.com/ansible/docsite/blob/main/ansible/11/.htaccess and https://github.com/ansible/docsite/blob/main/.htaccess in a way that is compatible with ReadTheDocs.
If this PR is accepted and merged, there are two follow on actions:
robots.txtfile to stop crawlers from indexing the generated HTML files. We can put therobots.txtfile in theansible/docsiterepo and copy it across as part of the ReadTheDocs build.docs/docsite/rst/user_guidefolder.