Do not strip file from container_volume_mounts #1410
Closed
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oraNod
reviewed
Feb 17, 2025
There was a problem hiding this comment.
Looks good to me for what that's worth. I didn't go so far as building off this branch and verifying the fix but the changes are really clear. I was also able to observe the issue of files getting stripped out with runner version 2.4.0 and podman.
I won't add approval because I'm not a maintainer and don't have much knowledge of the codebase. Just thought I'd give a +1 for what seems like a straightforward and useful fix from the community. Thanks @felixfontein
|
Closed by #1408 merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1409.