Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 Discover injectors through entrypoints #15595

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

webknjaz
Copy link
Member

This patch eliminates import-based injector discovery, switching to
distribution package-independent hosting of the respective callables.

@github-actions github-actions bot added component:api dependencies Pull requests that update a dependency file labels Oct 22, 2024
@webknjaz webknjaz force-pushed the features/inventory-entry-points branch from 27caa83 to 3fb65a3 Compare October 23, 2024 01:14
This patch eliminates import-based injector discovery, switching to
distribution package-indepdendent hosting of the respective callables.
@webknjaz webknjaz force-pushed the features/inventory-entry-points branch from 3fb65a3 to 5b13fde Compare October 23, 2024 01:24
@webknjaz webknjaz closed this Oct 23, 2024
@webknjaz webknjaz reopened this Oct 23, 2024
TODO: Revert this commit before merging!
@webknjaz webknjaz force-pushed the features/inventory-entry-points branch from 5b13fde to a8dd593 Compare October 23, 2024 13:56
@webknjaz webknjaz closed this Oct 23, 2024
@webknjaz webknjaz reopened this Oct 23, 2024
Copy link

sonarcloud bot commented Oct 23, 2024

@chrismeyersfsu
Copy link
Member

This is a better solution than our existing one for discovering the ManagedCredentialType custom injectors. However, our long term goal is to get rid of these custom injectors and build the general functionality into the injector templating. So I lean more towards getting rid of this "problem" by bringing these custom injectors closer to the ManagedCredentialType they are related to.

@webknjaz
Copy link
Member Author

@chrismeyersfsu agreed. I'll keep the PR open until that happens, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants