-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull the correct collection plugin for the product #15658
Open
jessicamack
wants to merge
15
commits into
ansible:devel
Choose a base branch
from
jessicamack:inv-plugin-split
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+20
−9
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4bf0ba8
pull the correct collection plugin for the product
jessicamack bdcc1c4
remove unused import and logging line
jessicamack 0d5f7dc
refactor code to load entry points
jessicamack 18d1019
reformat method
jessicamack bb4203c
lint fix
jessicamack ee928ae
renames for clarity and a lint fix
jessicamack 912e450
move function to utils
jessicamack ddc521c
move the rest of the code into load_inventory_plugins
jessicamack 9a2f15b
temp - confirm that tests will pass
jessicamack 6c8d914
Merge branch 'devel' into inv-plugin-split
jessicamack 8f4e49e
revert change caught in merge
jessicamack 1891837
Merge branch 'devel' into inv-plugin-split
jessicamack 8017020
change back requirement
jessicamack 6c21136
Merge branch 'devel' into inv-plugin-split
jessicamack 326a810
Merge branch 'devel' into inv-plugin-split
jessicamack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what the
/
is doing here? Maybe it's a new python thing I'm unaware of, but maybe it's unintended.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my understanding is that it's using this syntax https://docs.python.org/3.8/whatsnew/3.8.html#positional-only-parameters. it was suggested by @webknjaz here #15658 (comment). I think it's to enforce standard behavior.