cli: set non-zero return code for canceled status
#15678
Conversation
|
|
@ryanpetrello @AlanCoding I'm tagging you because you participated in the original implementation (#6081). What do you think of this enhancement? |
|
Hey @mhassan1, @AlanCoding can probably answer best - I'm no longer an active contributor to AWX. |
|
Hello @mhassan1, thank you for your contribution! We like the idea of your PR, but would prefer that cancelled return a different code than that of failed or error. Would you be open to modifying that in this PR? |
|
|
@djyasin I've updated the PR to set exit code 2 for the |
|
Thank you so much! We will review these changes and get back to you soon! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. |
|
hey @mhassan1 thanks for the contribution and updating the error code. everything looks good! |
SUMMARY
This PR adds
canceledto the list of statuses that causelaunchcommands (with--monitoror--wait) to exit non-zero.If a job is canceled, I expect the caller to get a non-zero return code; otherwise, the caller will think that the job completed successful, even though it did not.
This is a follow-up to #6081.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
N/A