Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set default pull policy for ee #15824

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

kk-at-redhat
Copy link
Contributor

SUMMARY

Ability to switch execution environment pull policy to "---------" - default option

related #15821

ISSUE TYPE

Bug, Docs Fix or other nominal change

COMPONENT NAME

Collection

AWX VERSION
4.6.7
ADDITIONAL INFORMATION

Testing

ansible -m ansible.controller.execution_environment --args="name='B' image='aap-hub.int/ee-minimal-rhel8:latest' pull='missing'" localhost

localhost | CHANGED => {
    "changed": true,
    "id": 6
}

ansible -m ansible.controller.execution_environment --args="name='B' image='aap-hub.int/ee-minimal-rhel8:latest' pull=''" localhost

localhost | CHANGED => {
    "changed": true,
    "id": 6
}

ansible -m ansible.controller.execution_environment --args="name='B' image='aap-hub.int/ee-minimal-rhel8:latest' pull='never'" localhost

localhost | CHANGED => {
    "changed": true,
    "id": 6
}

ansible -m ansible.controller.execution_environment --args="name='B' image='aap-hub.int/ee-minimal-rhel8:latest' pull=''" localhost

localhost | CHANGED => {
    "changed": true,
    "id": 6
}

@github-actions github-actions bot added component:awx_collection issues related to the collection for controlling AWX community labels Feb 8, 2025
Copy link

sonarqubecloud bot commented Feb 8, 2025

@@ -55,7 +55,7 @@
pull:
description:
- determine image pull behavior
choices: ["always", "missing", "never"]
choices: ["", "always", "missing", "never"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to call the new option default instead of an empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do that we'd need to change export module and API because currently it's exporting as an empty value.
Not sure why we'd want to go through all these exercises. Let's just stick to the fundamental KISS principle :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community component:awx_collection issues related to the collection for controlling AWX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants