[Draft] Add concept of priority to job templates and jobs #15889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example ordering of how jobs would be looked at by the task manager: |
|
Doesn't this carry a core assumption that multiple jobs are processed in a single task manager run? It is likely that the task manager dispatches one job at a time, in which case it goes in the order the task manager gets them, and this priority metric would not matter at all. |
|
yes this is only applicable when there are many jobs in pending. So it only really applies when you have more jobs in pending than you have capacity to run. |
This adds concept of priority to jobs. The task manager now orders on priority, then created. All rules around instance group capacity etc still apply. So even if a job has very high priority, if there is not available capacity in the available instance groups, it will not be scheduled. Higher number is higher priority. Default priority is 0. For dependencies spawned from other jobs, assign them the priority of the job that caused them to be created. Still need to add prompt on launch stuff for priority to be consistent.
kdelee
force-pushed
the
priority_task_manager
branch
from
3aab0cb to
d65ab1c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds concept of priority to jobs.
The task manager now orders on priority, then created. All rules around instance group capacity etc still apply. So even if a job has very high priority, if there is not available capacity in the available instance groups, it will not be scheduled.
Higher number is higher priority.
Default priority is 0.
For dependencies like project updates + inventory source updates spawned from other jobs, assign them the priority of the job that caused them to be created.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Not currently addressed/questions: