Add capability to return gdc property as any #2422
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2422 +/- ##
==========================================
+ Coverage 84.16% 84.19% +0.03%
==========================================
Files 91 91
Lines 10597 10599 +2
==========================================
+ Hits 8919 8924 +5
+ Misses 1678 1675 -3 |
|
Pull request documentation preview limit (10) reached: skipping documentation deployment for this pull request. |
| gdc = dpf.GenericDataContainer(server=server_type) | ||
| entity = dpf.DataTree(server=server_type) | ||
| entity.add(name="john") | ||
| gdc.set_property("persons", entity) |
There was a problem hiding this comment.
@cbellot000 shouldn't the set_property be called with entity as Any?
There was a problem hiding this comment.
I don't see why @PProfizi, it's a data tree, not an any. Getting as any is possible on any data type (DataTree is just an example here)
There was a problem hiding this comment.
I mean, the test is called test_set_get_any_generic_data_container, I thought this meant you would test setting and getting an Any.
There was a problem hiding this comment.
Sorry, I misunderstood the PR
No description provided.