Skip to content

Clean-up try-except-pass patterns #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

PProfizi
Copy link
Contributor

No description provided.

@PProfizi PProfizi self-assigned this Aug 20, 2025
@PProfizi PProfizi requested a review from a team as a code owner August 20, 2025 13:44
Copy link

codecov bot commented Aug 20, 2025

❌ 412 Tests Failed:

Tests completed Failed Passed Skipped
21326 412 20914 3300
View the top 3 failed test(s) by shortest run time
tests/test_operator.py::test_deep_copy_non_ascii_string[gRPC CLayer]
Stack Traces | 0.003s run time
server_type = <ansys.dpf.core.server_types.GrpcServer object at 0x7f3f8a1e57b0>

    @pytest.mark.skipif(
        not SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_8_0, reason="Available for servers >=8.0"
    )
    def test_deep_copy_non_ascii_string(server_type):
        str = "\N{GREEK CAPITAL LETTER DELTA}"
>       str_out = dpf.core.core._deep_copy(str, server_type)

tests/test_operator.py:1409: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
..../test-api/lib/python3.10.../dpf/core/core.py:308: in _deep_copy
    stream_type = 1 if server_meet_version(required_version="8.0", server=entity_server) else 0
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

required_version = '8.0', server = None

    def server_meet_version(required_version: str, server: AnyServerType) -> bool:
        """Check if a given server version matches with a required version.
    
        Parameters
        ----------
        required_version:
            Required version to compare with the server version.
        server:
            DPF server object.
    
        """
>       return server.meet_version(required_version)
E       AttributeError: 'NoneType' object has no attribute 'meet_version'

..../test-api/lib/python3.10.../dpf/core/check_version.py:53: AttributeError
tests\test_operator.py::test_operator::test_deep_copy_non_ascii_string[gRPC CLayer]
Stack Traces | 0.003s run time
server_type = <ansys.dpf.core.server_types.GrpcServer object at 0x0000024309DC21A0>

    @pytest.mark.skipif(
        not SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_8_0, reason="Available for servers >=8.0"
    )
    def test_deep_copy_non_ascii_string(server_type):
        str = "\N{GREEK CAPITAL LETTER DELTA}"
>       str_out = dpf.core.core._deep_copy(str, server_type)

tests\test_operator.py:1409: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox\test-api\lib\site-packages\ansys\dpf\core\core.py:308: in _deep_copy
    stream_type = 1 if server_meet_version(required_version="8.0", server=entity_server) else 0
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

required_version = '8.0', server = None

    def server_meet_version(required_version: str, server: AnyServerType) -> bool:
        """Check if a given server version matches with a required version.
    
        Parameters
        ----------
        required_version:
            Required version to compare with the server version.
        server:
            DPF server object.
    
        """
>       return server.meet_version(required_version)
E       AttributeError: 'NoneType' object has no attribute 'meet_version'

.tox\test-api\lib\site-packages\ansys\dpf\core\check_version.py:53: AttributeError
tests\test_operator.py::test_operator::test_deep_copy_non_ascii_string[gRPC CLayer]
Stack Traces | 0.003s run time
server_type = <ansys.dpf.core.server_types.GrpcServer object at 0x00000272B38C0790>

    @pytest.mark.skipif(
        not SERVERS_VERSION_GREATER_THAN_OR_EQUAL_TO_8_0, reason="Available for servers >=8.0"
    )
    def test_deep_copy_non_ascii_string(server_type):
        str = "\N{GREEK CAPITAL LETTER DELTA}"
>       str_out = dpf.core.core._deep_copy(str, server_type)

tests\test_operator.py:1409: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox\test-api\lib\site-packages\ansys\dpf\core\core.py:308: in _deep_copy
    stream_type = 1 if server_meet_version(required_version="8.0", server=entity_server) else 0
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

required_version = '8.0', server = None

    def server_meet_version(required_version: str, server: AnyServerType) -> bool:
        """Check if a given server version matches with a required version.
    
        Parameters
        ----------
        required_version:
            Required version to compare with the server version.
        server:
            DPF server object.
    
        """
>       return server.meet_version(required_version)
E       AttributeError: 'NoneType' object has no attribute 'meet_version'

.tox\test-api\lib\site-packages\ansys\dpf\core\check_version.py:53: AttributeError

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

github-actions bot commented Aug 21, 2025

Some tests with 'continue-on-error: true' have failed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant