Enhanced Images Initial Version #310
Conversation
…yuanrui/enhanced_images
…amicreporting into feat/yuanrui/enhanced_images
…yuanrui/enhanced_images
…yuanrui/enhanced_images
…yuanrui/enhanced_images
…yuanrui/enhanced_images
… both single and multiple fields
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=======================================
Coverage ? 78.61%
=======================================
Files ? 26
Lines ? 7231
Branches ? 1343
=======================================
Hits ? 5685
Misses ? 1126
Partials ? 420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@zhang-yuanrui Hey. Some of the existing files in the branch have been deleted, I'm assuming mistakenly. Also there are merge conflicts. |
zhang-yuanrui
force-pushed
the
feat/yuanrui/enhanced_images
branch
from
fdda0ef to
a8b6d9a
Compare
@viseshrp Thank you for pointing it out. I did a reset and everything should be sync'ed now. |
|
@zhang-yuanrui Also, please make sure project coverage is beyond 80% before merging. Thanks |
| HAS_VTK = True | ||
| except ImportError as e: # pragma: no cover | ||
| HAS_VTK = False | ||
| print(e) |
There was a problem hiding this comment.
I think you can get rid of the print statements. If you do want the user to know, use logging.info or logging.warn
| "pyvista==0.45.2", | ||
| "vtk==9.4.2", | ||
| "ansys-dpf-core==0.13.8", | ||
| ] | ||
| test-extra = [ |
There was a problem hiding this comment.
This is probably from the merge as well and needs to be reset.
There was a problem hiding this comment.
@viseshrp No, it is intentional. I moved pyvista, vtk and ansys-dpf-core to "test"
There was a problem hiding this comment.
@zhang-yuanrui This was the original block in the main branch.
[project.optional-dependencies]
test = [
"pytest>=8.3.3",
"pytest-cov>=6.0.0",
]
test-extra = [
"pyvista==0.45.2",
"vtk==9.4.2",
"ansys-dpf-core==0.13.8",
]
If you want to move everything in test-extra, remove test-extra completely.
| "pyvista==0.45.2", | ||
| "vtk==9.4.2", | ||
| "ansys-dpf-core==0.13.8", | ||
| ] | ||
| test-extra = [ |
There was a problem hiding this comment.
@zhang-yuanrui This was the original block in the main branch.
[project.optional-dependencies]
test = [
"pytest>=8.3.3",
"pytest-cov>=6.0.0",
]
test-extra = [
"pyvista==0.45.2",
"vtk==9.4.2",
"ansys-dpf-core==0.13.8",
]
If you want to move everything in test-extra, remove test-extra completely.
In this PR, it supports enhanced images (aka, deep pixel images) from DPF models.
Currently, it supports both nodal and elemental data as variables. As there are some restrictions when displaying TIFF images with more than 3 pages, although building and storing such images is not a problem, plotting vector variables has to be divided into 3 separate steps (x, y and z).
Some known issues: