Skip to content

ci: Add hooks to the .pre-commit-config.yaml file #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pyansys-automation
Copy link
Contributor

Checked the following hooks exist in the .pre-commit-config.yaml file:

ansys/pre-commit-hooks: add-license-headers

Feel free to edit the changes in the pull request if necessary.

Important

If the add-license-headers hook was added to the file, pull the maint/automated-hook-update branch and run pre-commit run --all-files locally to add the license headers to the files. See the add-license-headers setup for more guidance on how to set up the hook.


This pull request was created by a bot. If you have any questions, please ping the PyAnsys Core team for assistance. To ping the team write a comment in this issue with the following mention: @ansys/pyansys-core.

If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.

@viseshrp viseshrp closed this Jun 13, 2025
@viseshrp viseshrp reopened this Jun 13, 2025
@viseshrp viseshrp requested review from viseshrp and removed request for margalva June 13, 2025 18:53
@viseshrp viseshrp closed this Jun 17, 2025
@RobPasMue
Copy link
Member

@viseshrp - what was the reason for closing this PR? The license headers are necessary in all PyAnsys libraries, it is a legal requirement and the hook needs to be added.

If you want to open a separate PR with the following change:

- repo: https://github.com/ansys/pre-commit-hooks
  rev: v0.5.2
  hooks:
  - id: add-license-headers
    args:
    - --start_year=2023

That's also fine, but the change is necessary.

@viseshrp
Copy link
Collaborator

@viseshrp - what was the reason for closing this PR? The license headers are necessary in all PyAnsys libraries, it is a legal requirement and the hook needs to be added.

If you want to open a separate PR with the following change:

- repo: https://github.com/ansys/pre-commit-hooks
  rev: v0.5.2
  hooks:
  - id: add-license-headers
    args:
    - --start_year=2023

That's also fine, but the change is necessary.

Right. There were other changes that were unnecessary. I am including it manually in another PR of mine.

@viseshrp viseshrp deleted the maint/automated-hook-update branch June 17, 2025 20:05
@RobPasMue
Copy link
Member

Okay good - as long as it's in I am fine with it - thanks @viseshrp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants