-
Notifications
You must be signed in to change notification settings - Fork 50
feat: Get raw value for faces connectivity data. #4244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@abhishekchitwar, this will suffice the requirement you had for getting raw data from faces_connectivity? |
Thanks, @prmukherj! This avoids the need to explicitly flatten the face connectivity data when converting it to VTK or any other format. |
@abhishekchitwar, we have decided to update the behavior so as to return the flat structure by default. So no changes required from your end to flatten it out or to add the flag. Thank you. |
@prmukherj We did propose deprecating the previous format, which would usually imply initially providing a separate, temporary means for accessing the new format (possibly a different |
I believe it would be good to introduce a |
yes, doing that only. Just that the flatten behavior will be the default one later, going forward. So we need a deprecation message. |
This feature updates existing method to add a flag "flatten_connectivity" which changes its default return types to retrieve raw face connectivity data from surface field queries. It enables advanced users to directly access the vertex indices that define each face, which can be useful for custom post-processing or geometry interpretation.
Key Changes
Example usage:
Notes
Please see tests and documentation for detailed usage.