feat: using dpf instead of reader in "results" module #1300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (59.09%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1300 +/- ##
==========================================
- Coverage 89.17% 85.50% -3.67%
==========================================
Files 187 189 +2
Lines 14970 15619 +649
==========================================
+ Hits 13349 13355 +6
- Misses 1621 2264 +643 🚀 New features to boost your workflow:
|
|
Fundamentally, this all needs to be moved to DPF-Post and DPF post needs to have an even simpler API. Right now we have:
I'd rather not make a 5th. There's a potential new hire that will work for the PyAnsys team on DPF-Post and I'd like him to work on this along with you. |
Added `_get_nodes_for_argument`, `principal_nodal_stress`, and `element_components`.
… docker run command
…nd improve docker command construction
…pdl_logs_remote.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.
The key is to replace the class
ansys-mapdl-reader.rst.Resultby some class which provides the same interface. The complete lists of functions in that class are:Show list of Result class functions
However, I'm planning to migrate only the public ones:
Core
Launch DPF when running in containerThis should not be part of PyMAPDL since if it is local, it will be automatically detected, and if it is remote, we should not own that resource. It could be something for PyMAPDL developers.MapdlGrpcclass.To migrate
available_resultscylindrical_nodal_stresselement_componentselement_lookupelement_solution_dataThis requires a mapping sort of:
element_stressfilenamematerialsSee:mesh: Requires replicate a full class. It will be a different issue.n_resultsn_sectornodal_accelerationnodal_boundary_conditionsnodal_displacementnodal_elastic_strainnodal_input_forcenodal_plastic_strainnodal_reaction_forcesnodal_solutionnodal_static_forcesnodal_stressnodal_temperaturenodal_thermal_strainnodal_time_historynodal_velocitynode_componentsparse_coordinate_systemparse_step_substeppathlib_filenameprincipal_nodal_stressresult_dof: Return a list of degrees of freedom for a given result number.section_datatime_valuesversionNext PRs
Mesh object
Plotting PR
animate_nodal_displacementanimate_nodal_solutionanimate_nodal_solution_setplotplot_cylindrical_nodal_stressplot_element_resultplot_nodal_displacementplot_nodal_elastic_strainplot_nodal_plastic_strainplot_nodal_solutionplot_nodal_stressplot_nodal_temperatureplot_nodal_thermal_strainplot_principal_nodal_stressVTK PR
save_as_vtkThis is going to require a separate package.
To not migrate.
A
NotImplementedErrorwill be raised.cs_4x4- I couldn't make it work locally, so I'm not porting it. It will raise a not implemented error.solution_infoIt doesn't make sense to be ported, because of this type of information is hidden in DPF.
text_result_tableUsed for the text in the plots. Not porting it.
write_tables: Write binary tables to ASCII.read_record: Read a record from the opened file. Records are hidden in DPF.overwrite_element_solution_record: DPF cannot write solution files.overwrite_element_solution_records: DPF cannot write solution files.There are many methods which are duplicate from
mapdl.post_processing, I will probably redirect one to another (I don't know which one should prevail, probably post-processing).Summary by Sourcery
Replace the legacy reader‐based results interface with a new DPF backend: introduce a global switch to toggle backends, implement and expose the
DPFResultclass with migrated public APIs using ansys-dpf-core, update test infrastructure and CI workflows to support DPF testing, and refine misc, launcher, and pytest utilities to accommodate the change.New Features:
use_reader_backendswitch in MAPDL.DPFResultclass underansys.mapdl.core.reader.resultmigrating public result APIs to use ansys-dpf-core.get_ipandparse_ip_routefor IP detection and switch GRPC/Docker connection logic.Bug Fixes:
MapdlGrpc.sysand clarify assertion error when reusing MAPDL instances.Enhancements:
PYMAPDL_ADDITIONAL_SWITCHESin headers.mapdl.resultfile‐path handling to create isolated temp directories and enrich FileNotFoundError messages._parse_ip_routeusage in launcher and misc modules.CI:
TEST_DPF_BACKENDenvironment variable in CI workflows to enable/disable DPF tests.Documentation:
Tests:
tests/test_result.pyand update fixtures fortest_dpf_backend.tests/conftest.py,tests/common.py, and test launcher to integrate DPF backend testing.