Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python 3.12. #2244

Closed
wants to merge 5 commits into from
Closed

Adding python 3.12. #2244

wants to merge 5 commits into from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 11, 2023

As the title.

@germa89 germa89 self-assigned this Aug 11, 2023
@germa89 germa89 requested a review from clatapie August 11, 2023 15:51
@germa89 germa89 enabled auto-merge (squash) August 11, 2023 15:51
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Merging #2244 (72ce1b3) into main (b84acb7) will increase coverage by 5.98%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2244      +/-   ##
==========================================
+ Coverage   81.93%   87.92%   +5.98%     
==========================================
  Files          44       44              
  Lines        8453     8453              
==========================================
+ Hits         6926     7432     +506     
+ Misses       1527     1021     -506

@germa89 germa89 mentioned this pull request Aug 11, 2023
Closed
4 tasks
@germa89
Copy link
Collaborator Author

germa89 commented Aug 11, 2023

Closing because python 3.12 is still in Release Candidate status.

@germa89 germa89 closed this Aug 11, 2023
auto-merge was automatically disabled August 11, 2023 17:24

Pull request was closed

@germa89 germa89 deleted the maint/adding-python-3.12 branch August 11, 2023 17:25
@germa89 germa89 restored the maint/adding-python-3.12 branch October 9, 2023 17:01
@germa89 germa89 reopened this Oct 9, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Oct 13, 2023

Still no vtk version for python 3.12. Closing PR for the moment.

@germa89 germa89 closed this Oct 13, 2023
@germa89 germa89 deleted the maint/adding-python-3.12 branch November 22, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie Awaiting requested review from clatapie

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@germa89