Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update the tox.ini to different tox env #3164
base: main
Are you sure you want to change the base?
fix: Update the tox.ini to different tox env #3164
Changes from 17 commits
74dda02
c47f466
a5e4be0
1c61a30
e514d99
7706b24
56cabe5
97667f7
514a371
c5f9697
2a40945
2bae4dd
1d2585f
1ddd1e6
e9e01f5
1c00997
24fa784
58aaebb
f96b7b6
981f269
dca0d42
edb007c
cf41c39
b707026
ad8e462
d3e70d2
9037c89
bf0bb9d
c82d9e0
cdbde4b
8159e5d
1adab82
51f6d5e
e2a3f45
2265269
801800f
f167caf
cd5998e
6b1094e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Login is no longer required since users can build the images locally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, @germa89.
We should take advantage of this and add a rule for building a docker image locally. This will help us to review the
docker/
directory and the current image building process.This directory could look like this:
Users should just copy MAPDL artifacts in the
distributions/
dir. Then, running:tox -e docker-build-images
would trigger thedocker-compose.yml
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Building the docker image is a bit complex.. because the
dockerignore
depends on the MAPDL version.The
docker
directory is not used by the CICD nor myself to build the docker image at the moment, hence it is not fully maintained.We have some instructions about building the docker image in: https://mapdl.docs.pyansys.com/version/stable/getting_started/make_container.html
We could meet next week to discuss this more in details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.