-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: check no instances are left between tests #3257
Closed
germa89
wants to merge
13
commits into
main
from
feat/checking-no-instances-are-left-after-each-test
Closed
test: check no instances are left between tests #3257
germa89
wants to merge
13
commits into
main
from
feat/checking-no-instances-are-left-after-each-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
July 9, 2024 12:23
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
clatapie
reviewed
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
- Coverage 86.61% 83.53% -3.08%
==========================================
Files 53 53
Lines 9630 9629 -1
==========================================
- Hits 8341 8044 -297
- Misses 1289 1585 +296 |
Forced to be implemented in #3266, so I merged there. Closing this. |
germa89
deleted the
feat/checking-no-instances-are-left-after-each-test
branch
October 7, 2024 14:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title
Issue linked
Close #3254
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)