Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check no instances are left between tests #3257

Closed

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 9, 2024

Description

As the title

Issue linked

Close #3254

Checklist

@germa89 germa89 requested a review from a team as a code owner July 9, 2024 12:23
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 9, 2024 12:23
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jul 9, 2024
@germa89 germa89 self-assigned this Jul 9, 2024
tests/conftest.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.53%. Comparing base (9047d71) to head (bef97e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
- Coverage   86.61%   83.53%   -3.08%     
==========================================
  Files          53       53              
  Lines        9630     9629       -1     
==========================================
- Hits         8341     8044     -297     
- Misses       1289     1585     +296     

@germa89 germa89 mentioned this pull request Jul 9, 2024
10 tasks
@germa89
Copy link
Collaborator Author

germa89 commented Jul 12, 2024

Forced to be implemented in #3266, so I merged there. Closing this.

@germa89 germa89 closed this Jul 12, 2024
@germa89 germa89 deleted the feat/checking-no-instances-are-left-after-each-test branch October 7, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test not stopping MAPDL instances properly
3 participants