fix: not showing instances on linux #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/pool-issues #3263 +/- ##
====================================================
- Coverage 87.96% 62.98% -24.98%
====================================================
Files 53 53
Lines 9670 9670
====================================================
- Hits 8506 6091 -2415
- Misses 1164 3579 +2415 |
germa89
added a commit
that referenced
this pull request
Jul 12, 2024
* feat: adding port to exception message * fix: attempt tests before being ready * feat: changing arguments order * chore: wait for complete exit * test: raise exception if mapdl instances are alive between tests * chore: adding changelog file 3257.added.md * fix: adding missing import * fix: adding missing object * test: check process status * fix: running process check only on local. * feat: enforcing having exactly the amount of instances specified. Adding timeout to check if the instance is already launched. * feat: adding a timeout before moving on * fix: latest_version env var * feat: added pool_creator fixture. We use pool fixture to check pool health. fix: some tests * fix: NoSuchProcess error. Small cosmetic fix * chore: adding changelog file 3266.fixed.md * chore: adding changelog file 3266.fixed.md * refactor: small reog * test: activating previously skipped tests * fix: test * fix: adding port to avoid port collision * fkix: tests * docs: adding comments * feat: adding ``ready`` property and ``wait_for_ready`` method. fix: Making sure we restart the instance on the same path. refactor: waiting for the instance to get ready. test: added test to check directory names when there is a restart. * feat: Checking ports from the cmdline * fix: tests * fix: early exit in process check to avoid accessdenied. * Revert "fkix: tests" This reverts commit d58971b. * feat: catching already dead process. * fix: pymapdl list not showing any instance because name method wasn't called. * feat: wrapping process checking in a try/except to avoid calling already dead process * feat: using dynamic port in test_cli. Starting and stopping another instance. * fix: test * refactor: reducing code duplicity * feat: making sure we stop MAPDL if failure * fix: test_remove_temp_dir_on_exit on windows * test: without rerun * ci: using v24.2 for docs building * fix: exception in list instance processing * feat: using PORT1 variable refactor: moving console test to test_console * fix: tests * ci: run all tests * test: testing * test: no raise exception. * ci: increasing timeout for local and min jobs * chore: adding logging statements. * test: marking tests as xfail * ci: adding back pytest config * Revert "build: update ansys-api-mapdl to 0.5.2 (#3255)" This reverts commit 0bcf344. * test: skip flaky tests * build: update ansys-api-mapdl to 0.5.2 (#3255) * build: update ansys-api-mapdl to 0.5.2 * chore: adding changelog file 3255.dependencies.md --------- Co-authored-by: pyansys-ci-bot <[email protected]> * test: skip flaky test. See #2435 comment * fix: not showing instances on linux (#3263) * fix: not showing instances on linux * chore: adding changelog file 3263.fixed.md --------- Co-authored-by: pyansys-ci-bot <[email protected]> * ci: undo some stuff * test: adding some waiting time after attempting to kill instance. * fix: missing import. * chore: remove fragment from other PR. --------- Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)