Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python3.9 support #3326

Merged
merged 4 commits into from
Aug 20, 2024
Merged

chore: drop python3.9 support #3326

merged 4 commits into from
Aug 20, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 5, 2024

Description

Dropping python3.9 official support.

Using python3.11 for official testing.

However, I am going to keep one outdated version (python3.9) as part of the CICD, just testing installation and imports. Nevermind, to do this I need to install the library with --ignore-requires-python argument but since we are using an ansys/action probably it is not worthy to remove completely the action just for this smoke test.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner August 5, 2024 08:06
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team August 5, 2024 08:06
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) enhancement Improve any current implemented feature CI/CD Related with CICD, Github Actions, etc labels Aug 5, 2024
@germa89 germa89 self-assigned this Aug 5, 2024
@germa89 germa89 enabled auto-merge (squash) August 5, 2024 09:35
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (a050034) to head (c090c08).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   87.17%   87.12%   -0.06%     
==========================================
  Files          55       55              
  Lines        9773     9773              
==========================================
- Hits         8520     8515       -5     
- Misses       1253     1258       +5     

@germa89 germa89 merged commit 5a29cdb into main Aug 20, 2024
68 checks passed
@germa89 germa89 deleted the maint/drop-python3.9-support branch August 20, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc dependencies enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants