Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding channel subscription method and tests #3340

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Aug 8, 2024

Description

Adding a method to retrieve the gRPC channel status through channel subscription.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner August 8, 2024 18:16
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team August 8, 2024 18:16
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Aug 8, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Aug 8, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Aug 8, 2024

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.12%. Comparing base (a8b1514) to head (a51a318).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   87.13%   87.12%   -0.02%     
==========================================
  Files          55       55              
  Lines        9773     9810      +37     
==========================================
+ Hits         8516     8547      +31     
- Misses       1257     1263       +6     

@germa89
Copy link
Collaborator Author

germa89 commented Aug 9, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 6b6b797 into main Aug 9, 2024
65 of 66 checks passed
@germa89 germa89 deleted the feat/adding-channel-subscription branch August 9, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants