-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding 'methodconfig' for all services in channel to allow retry #3343
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Way to test this, using the model from #2479 connecting to v25.1.0 docker image. Then run: python compute_for_multiple_mesh_size_wb.py > log.log 2>&1 and then: $ tail -n 600 -f log.log | grep retrying
I0808 22:01:08.049285000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 30 ms
I0808 22:01:08.082253000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 73 ms
I0808 22:01:08.158568000 6143717376 retry_filter_legacy_call_data.cc:2001] chand=0x137076210 calld=0x156e982d0: retrying failed call in 310 ms |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
==========================================
- Coverage 87.13% 86.96% -0.17%
==========================================
Files 55 55
Lines 9816 10959 +1143
==========================================
+ Hits 8553 9531 +978
- Misses 1263 1428 +165 |
I saw this:
strange |
Pinging @greschd in case he has any experience with this topic. |
I guess it is time for... @pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Implement gRPC retries. It should improve the stability of the gRPC interface.
Issue linked
It should also close a lot of issues:
Close #3342 and related.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)