Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checking port on non-grpc mapdl instances #3540

Merged
merged 2 commits into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/3540.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix: checking port on non-grpc mapdl instances
6 changes: 5 additions & 1 deletion src/ansys/mapdl/core/cli/list_instances.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,13 @@
ind_grpc = cmdline.index("-port")
return cmdline[ind_grpc + 1]

def is_grpc_based(proc):
cmdline = proc.cmdline()
return "-grpc" in cmdline

Check warning on line 130 in src/ansys/mapdl/core/cli/list_instances.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/mapdl/core/cli/list_instances.py#L128-L130

Added lines #L128 - L130 were not covered by tests

table = []
for each_p in mapdl_instances:
if instances and not each_p.ansys_instance:
if not each_p.ansys_instance or not is_grpc_based(each_p):

Check warning on line 134 in src/ansys/mapdl/core/cli/list_instances.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/mapdl/core/cli/list_instances.py#L134

Added line #L134 was not covered by tests
continue

proc_line = []
Expand Down
Loading