Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codecov.yml content #3542

Merged
merged 2 commits into from
Nov 13, 2024
Merged

chore: fix codecov.yml content #3542

merged 2 commits into from
Nov 13, 2024

Conversation

SMoraisAnsys
Copy link
Contributor

Description

While checking stuff in PyAEDT codecov result (use of multiple tags) I wanted to double check what was done in other repos. When checking the latest main's commit codecov I saw a warning, see below

image

This PR consists in fixing the "bug" that is reported by codecov.
To double check you can use the following command from the root of your repo
curl -X POST --data-binary @codecov.yml https://codecov.io/validate
Before the changes there is an error associated to "comment", now it's no longer present :)

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner November 8, 2024 11:07
@SMoraisAnsys SMoraisAnsys requested review from germa89 and pyansys-ci-bot and removed request for a team November 8, 2024 11:07
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added maintenance General maintenance of the repo (libraries, cicd, etc) enhancement Improve any current implemented feature labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (baa7ac0) to head (253521f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3542      +/-   ##
==========================================
+ Coverage   87.48%   91.28%   +3.80%     
==========================================
  Files          58      187     +129     
  Lines       10217    14641    +4424     
==========================================
+ Hits         8938    13365    +4427     
+ Misses       1279     1276       -3     

@germa89
Copy link
Collaborator

germa89 commented Nov 13, 2024

Thank you a lot for this @SMoraisAnsys !! :)

Close #3518

@germa89 germa89 merged commit fd28cd5 into main Nov 13, 2024
62 checks passed
@germa89 germa89 deleted the chore/fix-codecov-yaml branch November 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve any current implemented feature maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants