Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: remove importlib-metadata requirement #3546

Merged
merged 5 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ updates:
package-ecosystem: "pip" # See documentation for possible values
insecure-external-code-execution: allow
schedule:
interval: "weekly"
interval: "weekly"
day: "friday"
time: "00:00"
labels:
Expand All @@ -34,7 +34,6 @@ updates:
minimal:
patterns:
- "ansys-api-mapdl"
- "importlib-metadata"
- "numpy"
- "platformdirs"
- "psutil"
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/3546.documentation.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[maint] remove importlib-metadata requirement
2 changes: 0 additions & 2 deletions doc/source/examples/extended_examples/hpc/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ fonttools==4.49.0
geomdl==5.3.1
grpcio==1.62.0
idna==3.7.0
importlib-metadata==7.0.1
kiwisolver==1.4.5
matplotlib==3.8.3
numpy==1.26.4
Expand All @@ -40,4 +39,3 @@ tabulate==0.9.0
tqdm==4.66.3
urllib3==2.2.2
vtk==9.3.0
zipp==3.19.1
1 change: 0 additions & 1 deletion minimum_requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
ansys-api-mapdl==0.5.2
importlib-metadata==8.5.0
numpy==2.1.2
platformdirs==4.3.6
psutil==6.1.0
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ dependencies = [
"ansys-tools-path>=0.3.1",
"click>=8.1.3", # for CLI interface
"grpcio>=1.30.0", # tested up to grpcio==1.35
"importlib-metadata>=4.0",
"matplotlib>=3.0.0", # for colormaps for pyvista
"numpy>=1.14.0,<1.25.0; python_version < '3.9'",
"numpy>=1.14.0,<3.0.0; python_version >= '3.9'",
Expand Down
5 changes: 1 addition & 4 deletions src/ansys/mapdl/core/report.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,7 @@ def __init__(self, core, optional=None, additional=None, **kwargs):
self.kwargs["extra_meta"] = ("GPU Details", "None")

def get_version(self, package):
try:
import importlib.metadata as importlib_metadata
except ModuleNotFoundError: # pragma: no cover
import importlib_metadata
import importlib.metadata as importlib_metadata

try:
return importlib_metadata.version(package.replace(".", "-"))
Expand Down
Loading