Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gui-extended-example #3555

Merged
merged 12 commits into from
Nov 19, 2024
Merged

fix: gui-extended-example #3555

merged 12 commits into from
Nov 19, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 18, 2024

Description

Fix and improve the GUI example.

Issue linked

Close #3537

Checklist

@germa89 germa89 requested a review from a team as a code owner November 18, 2024 18:43
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 18, 2024 18:43
@germa89 germa89 self-assigned this Nov 18, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 requested a review from ansjhajjar November 18, 2024 18:43
@germa89 germa89 enabled auto-merge (squash) November 18, 2024 18:43
@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) bug Issue, problem or error in PyMAPDL labels Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (abcb5ae) to head (0d2b490).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3555      +/-   ##
==========================================
- Coverage   91.28%   91.27%   -0.02%     
==========================================
  Files         187      187              
  Lines       14638    14638              
==========================================
- Hits        13363    13361       -2     
- Misses       1275     1277       +2     
---- 🚨 Try these New Features:

@germa89
Copy link
Collaborator Author

germa89 commented Nov 18, 2024

Also close #3531

@germa89 germa89 linked an issue Nov 18, 2024 that may be closed by this pull request
@germa89
Copy link
Collaborator Author

germa89 commented Nov 19, 2024

@ansjhajjar, can you review this PR?

Copy link

@ansjhajjar ansjhajjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germa89 germa89 merged commit dff1bab into main Nov 19, 2024
60 of 62 checks passed
@germa89 germa89 deleted the fix/gui-extended-example branch November 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL documentation Documentation related (improving, adding, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI example seems not work MAPDLTheme not in ansys-mapdl-core
3 participants