Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: using find_mapdl instead of find_ansys #3560

Merged
merged 4 commits into from
Nov 22, 2024
Merged

refactor: using find_mapdl instead of find_ansys #3560

merged 4 commits into from
Nov 22, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 20, 2024

Description

As the title. Because find_ansys is going to be deprecated.

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 20, 2024 10:57
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 20, 2024 10:57
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature labels Nov 20, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 20, 2024

@pyansys-ci-bot LGMT.

@germa89 germa89 enabled auto-merge (squash) November 20, 2024 13:15
@germa89 germa89 self-assigned this Nov 21, 2024
@germa89 germa89 requested review from koubaa and ansjhajjar November 21, 2024 18:46
@germa89
Copy link
Collaborator Author

germa89 commented Nov 22, 2024

@pyansys-ci-bot LGTM.

pyansys-ci-bot
pyansys-ci-bot approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 4a2a9b3 into main Nov 22, 2024
60 checks passed
@germa89 germa89 deleted the refactor/removing-find_ansys branch November 22, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyansys-ci-bot pyansys-ci-bot pyansys-ci-bot approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

@koubaa koubaa Awaiting requested review from koubaa

@ansjhajjar ansjhajjar Awaiting requested review from ansjhajjar

Assignees

@germa89 germa89

Labels
documentation Documentation related (improving, adding, etc) enhancement Improve any current implemented feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@germa89 @pyansys-ci-bot