Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding-mode-warning #3574

Merged
merged 5 commits into from
Nov 25, 2024
Merged

feat: adding-mode-warning #3574

merged 5 commits into from
Nov 25, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 25, 2024

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 25, 2024 18:19
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 25, 2024 18:19
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 25, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (853daba) to head (0079d55).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3574      +/-   ##
==========================================
- Coverage   86.93%   86.93%   -0.01%     
==========================================
  Files         187      187              
  Lines       14616    14622       +6     
==========================================
+ Hits        12707    12711       +4     
- Misses       1909     1911       +2     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) November 25, 2024 19:19
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 3aa2a73 into main Nov 25, 2024
41 of 45 checks passed
@germa89 germa89 deleted the feat/adding-mode-warning branch November 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants