Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding check_has_mapdl #3576

Merged
merged 6 commits into from
Nov 26, 2024
Merged

feat: adding check_has_mapdl #3576

merged 6 commits into from
Nov 26, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 25, 2024

Description

Adding check_has_mapdl function.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner November 25, 2024 20:21
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 25, 2024 20:21
@germa89 germa89 self-assigned this Nov 25, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

To merge before #3573

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 25, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 25, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (853daba) to head (5b0e3b3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
+ Coverage   86.93%   86.98%   +0.04%     
==========================================
  Files         187      187              
  Lines       14616    14623       +7     
==========================================
+ Hits        12707    12720      +13     
+ Misses       1909     1903       -6     

@germa89
Copy link
Collaborator Author

germa89 commented Nov 26, 2024

Since we merged #3268 the tests take way longer...

@germa89 germa89 merged commit 76d8ee7 into main Nov 26, 2024
44 of 50 checks passed
@germa89 germa89 deleted the feat/adding-check_has_mapdl branch November 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Request or proposal for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants