refactor: small improvements to test settings #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
CI/CD
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3577 +/- ##
==========================================
- Coverage 87.13% 87.11% -0.02%
==========================================
Files 187 187
Lines 14660 14677 +17
==========================================
+ Hits 12774 12786 +12
- Misses 1886 1891 +5 |
…mapdl into ci/add-timeout-to-tests
github-actions
bot
added
the
documentation
germa89
commented
Dec 13, 2024
germa89
commented
Dec 13, 2024
germa89
commented
Dec 13, 2024
germa89
commented
Dec 13, 2024
germa89
commented
Dec 13, 2024
germa89
commented
Dec 13, 2024
10 tasks
germa89
changed the title
|
@pyansys-ci-bot LGTM. |
MaxJPRey
reviewed
Dec 24, 2024
| # If there is no result file, this fails. | ||
| try: | ||
| nsets = int(self.nsets) | ||
| except MapdlRuntimeError: |
There was a problem hiding this comment.
@germa89 Don't you want to write something down in the log about it?
MaxJPRey
reviewed
Dec 24, 2024
Comment on lines
+150
to
+152
| info += f"\tNumber of result sets: {nsets}\n" | ||
| info += f"\tCurrent load step: {self.load_step}\n" | ||
| info += f"\tCurrent sub step: {self.sub_step}\n" |
There was a problem hiding this comment.
sets, step, sub steps...
Remind me of the good old days with Mechanical. I am becoming rusty with it 😭 .
MaxJPRey
reviewed
Dec 24, 2024
|
|
||
| clear(mapdl) | ||
|
|
||
| # setup the full file |
There was a problem hiding this comment.
Suggested change
| # setup the full file | |
| # set up the full file |
MaxJPRey
reviewed
Dec 24, 2024
| mapdl.vmesh("all") | ||
|
|
||
| # Define a material (nominal steel in SI) | ||
| mapdl.mp("EX", 1, 210e9) # Elastic moduli in Pa (kg/(m*s**2)) |
There was a problem hiding this comment.
Suggested change
| mapdl.mp("EX", 1, 210e9) # Elastic moduli in Pa (kg/(m*s**2)) | |
| mapdl.mp("EX", 1, 210e9) # Elastic modulus in Pa (kg/(m*s**2)) |
MaxJPRey
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title. Let's explore why the tests are taking so long since #3268
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)